[PATCH] Actually close the xapian database in notmuch_database_close
olly at survex.com
Thu Mar 1 13:20:41 PST 2012
On Thu, Mar 01, 2012 at 07:59:30AM +0100, Justus Winter wrote:
> Olly wrote:
> >It is hard to say if calling close() is actually useful here from just
> >seeing the patch.
> Huh? I provided a test case...
I only saw the part of the patch Austin quoted in the mail he cc-ed to
> Quoting Austin Clements (2012-02-29 23:17:54)
> >Also, since close could throw an exception, it should get wrapped in a
> >try/catch like flush currently is.
> My interpretation of  was that Xapian::Database::close() does not
> throw any exceptions.
Sadly there's not full documentation of exceptions which can be thrown
by a particular method.
More information about the notmuch