[PATCH 0/5] Disable search.exclude_tags for 0.12
markwalters1009 at gmail.com
Wed Feb 29 10:13:04 PST 2012
As requested by David (Bremner) on irc here is a patch series
disabling the search.exclude_tags feature as a temporary measure for
the 0.12 release.
There are two options:
The first is to disable the addition of the new search.exclude_tags
item to the config file and stop setup from asking for it.
The second is to do the above and also disable the functionality in
notmuch-search.c and notmuch-count.c.
The idea is that this these are minimal (and thus relatively safe)
changes to make. With the first option users who have configured the
functionality for themselves (while using git) will still get the
feature: it just won't be pushed on users. With the second option the
festure will be completely disabled.
Essentially patch 1 implements the first option and patch 4 the second
option. The other patches in the series update the NEWS file, the man
page and the tests. If going for the first option then I would suggest
applying (in addition to patch 1) patch 2 (NEWS) and probably patch 3
(man) although as the functionality remains the latter is not strictly
necessary. The test patch (patch 5) is not necessary as the tests set
If going for the second option then all the patches are needed.
Finally, please could someone familiar with the config/setup code
check patch 1 carefully. I have never looked at that code before and
could easily have done something stupid.
Mark Walters (5):
config: disable addition of exclude tags for 0.12
NEWS: revert NEWS item for exclude tags for 0.12
man: remove search.exclude_tags from notmuch-config.1 for 0.12
cli: temporarily remove exclude tag support for 0.12
test: mark exclude tests broken for 0.12
NEWS | 18 ------------------
man/man1/notmuch-config.1 | 8 --------
notmuch-config.c | 3 +--
notmuch-count.c | 8 +-------
notmuch-search.c | 8 +-------
notmuch-setup.c | 19 +------------------
test/search | 2 ++
7 files changed, 6 insertions(+), 60 deletions(-)
More information about the notmuch