[RFC PATCH v2 0/3] notmuch-pick: an emacs threaded message view with split-pane
markwalters1009 at gmail.com
Sun Feb 12 13:51:20 PST 2012
On Sun, 12 Feb 2012 12:39:13 -0800, Jameson Graef Rollins <jrollins at finestructure.net> wrote:
> On Sun, 12 Feb 2012 18:49:36 +0000, Mark Walters <markwalters1009 at gmail.com> wrote:
> > Here is a rebased version of the notmuch-pick patch set
> > id:"87d39k1gvi.fsf at qmul.ac.uk". It now applies directly
> > to master since Jani's notmuch-show command line parsing
> > has been pushed.
> Hey, Mark. Thanks for working on this. However, none of the patches
> have commit messages, so there's no explanation for what any of the
> patches are supposed to do. This is particularly bothersome for the
> first patch, which introduces a lot of unexplained changes to the cli.
> I think I would like to review this patch set, since I think I'm
> interested in the functionality it may be introducing, but without any
> commit messages or explanation what the patches are meant to do it's
> kind of a non starter for me.
At the moment I was mostly looking for feedback on whether people like
the final outcome (i.e., whether people liked it enough to be worth
tidying). I will add comments on the first two patches.
More information about the notmuch