[PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply"
david at tethera.net
Fri Jan 6 03:57:41 PST 2012
On Fri, 06 Jan 2012 10:11:42 +0200, Jani Nikula <jani at nikula.org> wrote:
> IMHO the first is cleanest and unaffected by changes in
> notmuch_show_params_t, though might be surprising if you're not (yet)
> used to C99 designated initializers.
Obviously not ;). It would nice to have a consensus about the use of C99
features in the notmuch code. Personally I think it's fine, but I know
we have had some back and forth about e.g. mid-block variable declarations.
> In any case, in the current implementation only .part and .cryptoctx are
> initialized, and the rest of the fields are random. This needs to be
> fixed one way or another.
More information about the notmuch