[notmuch] [PATCH v2] notmuch.el: Make notmuch-show buffer name first subject, instead of thread-id
cworth at cworth.org
Wed Apr 7 10:46:01 PDT 2010
On Fri, 12 Feb 2010 17:19:23 -0500, Jesse Rosenthal <jrosenthal at jhu.edu> wrote:
> Change the buffer name to a uniquified subject of the thread (i.e. the
> subject of the first message in the thread) instead of the thread-id. This
> is more meaningful to the user, and will make it easier to scroll through
> numerous open buffers.
A very lovely change, Jesse! Thanks for this (which is now pushed). And
again, thanks to Sebastian for guiding the patch through the file
There is one minor issue with this patch which is that viewing an
identical thread more than once will bring up a new buffer rather than
re-using the existing buffer. But of course, we *want* a separate buffer
if the thread-ID is different but the (abbreviated) subject just happens
to match. So there would have to be something clever to do the right
thing here. I'm not making this minor regression block the patch, since
it's so nice otherwise.
> This version of the patch improves on the first version by ensuring that
> the buffer names are unique, and that the `notmuch-show' command can
> still be used interactively.
> Signed-off-by: Jesse Rosenthal <jrosenthal at jhu.edu>
> notmuch.el | 25 +++++++++++++++++++------
> 1 files changed, 19 insertions(+), 6 deletions(-)
That last paragraph above is good guidance for understanding the patch,
but not useful as part of the permanent commit history. So I removed it
before pushing the commit. In the future, you can put text like that
*after* the "---" just below your Signed-off-by and then "git am" will
automatically ignore it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the notmuch